andrewglowacki commented on a change in pull request #2337:
URL: https://github.com/apache/accumulo/pull/2337#discussion_r742166988
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
##########
@@ -763,7 +763,7 @@ public void run() {
log.trace("{} - binning {} mutations",
Thread.currentThread().getName(),
mutationsToSend.size());
addMutations(mutationsToSend);
- } catch (Exception e) {
+ } catch (Throwable e) {
updateUnknownErrors("Error processing mutation set", e);
Review comment:
@ctubbsii I see what you mean. I agree it is possible the OOM error is
never seen if for example a previously executing SendTask encounters a
different exception or error. I believe this would be the case if the error
occurred in SendTask though as well.
I think using addSupressed here makes sense, or a queue of Throwables
waiting to be thrown to he user via addSupressed. I can however also imagine a
case where that is never seen either. For example, if SendTask evokes a normal
server exception and then OOM occurs in a different SendTask after the user
retrieves the original exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
