Manno15 commented on a change in pull request #2349:
URL: https://github.com/apache/accumulo/pull/2349#discussion_r744947838
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
##########
@@ -1402,10 +1402,8 @@ public void loadTablet(TInfo tinfo, TCredentials
credentials, String lock,
synchronized (server.openingTablets) {
synchronized (server.onlineTablets) {
- // checking if this exact tablet is in any of the sets
- // below is not a strong enough check
- // when splits and fix splits occurring
-
+ // With splits occurring, checking if the current tablet
+ // is in any of the sets below may not be a strong enough check
Review comment:
This is mostly just a reorder of words of the original comment. I think
it would help to mention what the checks are doing, i.e. checking if the
current tablet overlaps any other in the set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
