DomGarguilo commented on pull request #2345: URL: https://github.com/apache/accumulo/pull/2345#issuecomment-996987978
The newest changes seem to be working except they only allow for specifically formatted properties. For example, if using nested properties like those [found in accumulo testing](https://github.com/apache/accumulo-testing/blob/main/conf/accumulo-testing.properties#L43-L48): ``` test.ci.common.accumulo.server.props=\ tserver.compaction.major.service.cs1.planner=org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner \ tserver.compaction.major.service.cs1.planner.opts.executors=\ [{"name":"small","type":"internal","maxSize":"16M","numThreads":8},\ {"name":"medium","type":"internal","maxSize":"128M","numThreads":4},\ {"name":"large","type":"internal","numThreads":2}] ``` The tool will not find the executor config since it is within `test.ci.common.accumulo.server.props`. We might be able to account for this by accepting an optional argument that points to the parent property (in this case `test.ci.common.accumulo.server.props`). This example is one of the test cases that is currently failing. For contrast, the following properties work fine with this tool: ``` tserver.compaction.major.service.cs1.planner=org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner tserver.compaction.major.service.cs1.planner.opts.executors=\ [{"name":"small","type":"internal","maxSize":"16M","numThreads":8},\ {"name":"medium","type":"internal","maxSize":"128M","numThreads":4},\ {"name":"large","type":"internal","numThreads":2}] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
