milleruntime commented on a change in pull request #2425:
URL: https://github.com/apache/accumulo/pull/2425#discussion_r790780739
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
##########
@@ -253,8 +254,10 @@ public TabletServerResourceManager(ServerContext context) {
final AccumuloConfiguration acuConf = context.getConfiguration();
long maxMemory = acuConf.getAsBytes(Property.TSERV_MAXMEM);
- boolean usingNativeMap =
- acuConf.getBoolean(Property.TSERV_NATIVEMAP_ENABLED) &&
NativeMap.isLoaded();
+ boolean usingNativeMap =
acuConf.getBoolean(Property.TSERV_NATIVEMAP_ENABLED);
+ if (usingNativeMap) {
+ NativeMapLoader.load();
Review comment:
You probably didn't think any changes needed to be made but I still
think it is presumptuous to merge a PR and mark comments resolved without an
approval of the PR. When I open a PR and if I don't change the code that
someone commented on, I usually let them decide if the conversation is resolved
or not. I know we don't have explicit rules for these type of situations, I
just find that it is the courteous thing to do when someone takes the time to
review my code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
