dlmarion commented on issue #2423: URL: https://github.com/apache/accumulo/issues/2423#issuecomment-1023158042
> do you think an upstream issue/PR to micrometer about this would be useful? I had found https://github.com/micrometer-metrics/micrometer/issues/1929, which is not specific to their ExecutorServiceMetrics class, but is where I got my information on how to remove the Meters from the MeterRegistry. We could submit an issue, but I see two possible solutions: 1. They provide a method in ExecutorServiceMetrics that performs the removal of the Meters for the user based on the ExecutorService name tag that they add. 2. Return a reference to all of the Meters created by ExecutorServiceMetrics to the caller so that the caller can remove them. I think that 2 above presents a problem for us as we would need to keep a reference to all Meters created for all ExecutorServices so that they could be cleaned up. Given that #2432 only creates metrics for long lived ExecutorService's, I'm of the opinion that we punt on this issue until someone submits a ticket asking us to provide metrics for all ExecutorServices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
