dlmarion commented on a change in pull request #2563:
URL: https://github.com/apache/accumulo/pull/2563#discussion_r824100754



##########
File path: 
server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java
##########
@@ -421,9 +421,17 @@ public void executeFateOperation(TInfo tinfo, TCredentials 
c, long opid, FateOpe
         if (!canMerge)
           throw new ThriftSecurityException(c.getPrincipal(), 
SecurityErrorCode.PERMISSION_DENIED);
 
-        Manager.log.debug("Creating merge op: {} {} {}", tableId, startRow, 
endRow);
-        goalMessage += "Merge table " + tableName + "(" + tableId + ") splits 
from " + startRow
-            + " to " + endRow;
+        String startRowStr = startRow.toString();
+        String endRowStr = endRow.toString();
+        if (startRowStr.isBlank())
+          startRowStr = "-inf";
+        if (endRowStr.isBlank())
+          endRowStr = "+inf";
+
+        Manager.log.debug("Creating merge op: {} from startRow: {} to endRow: 
{}", tableId,
+            startRowStr, endRowStr);
+        goalMessage += "Merge table " + tableName + "(" + tableId + ") splits 
from " + startRowStr
+            + " to " + endRowStr;

Review comment:
       I know this pre-dates this change, but this is creating like 7 String 
objects.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to