ctubbsii commented on code in PR #2609:
URL: https://github.com/apache/accumulo/pull/2609#discussion_r848916763
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java:
##########
@@ -377,6 +383,8 @@ public void run() {
} else {
authKeyWatcher = null;
}
+ MAX_WRITE_THREADS_DEFAULT =
+
getServerConfig().getConfiguration().getDefaultCount(Property.TSERV_WRITE_THREADS_MAX);
Review Comment:
I'm pretty sure they are both getting the default value for the same
property... but one is doing so using a new method that was added
unnecessarily. And, assigning it here isn't even necessary at all, because we
need to compare to `0`... `0` semantically means "unlimited" not `default`. If
the default was `100`, that doesn't mean we should have unlimited threads...
that would be *very* unusual semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
