DomGarguilo commented on issue #2642:
URL: https://github.com/apache/accumulo/issues/2642#issuecomment-1116379183

   Reading the related comments in #2620 it was also suggested that the 
serviceNames could be shorter Strings instead enums. It looks like we could 
potentially do something like this by defining constants in `ThriftClientTypes` 
and using those constants in place of the serviceNames:
   ```java
     final static String CLIENT_SERVICE = "cl";
     final static String COMPACTOR_SERVICE = "cm";
   
     ...
   
     public static final 
ThriftClientType<ClientService.Client,ClientService.Client.Factory> CLIENT =
         new ThriftClientType<>(CLIENT_SERVICE, new 
ClientService.Client.Factory());
   
     public static final ThriftClientType<CompactorService.Client,
         CompactorService.Client.Factory> COMPACTOR =
             new ThriftClientType<>(COMPACTOR_SERVICE, new 
CompactorService.Client.Factory());
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to