keith-turner commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r865380896
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java:
##########
@@ -453,26 +482,40 @@ public void run() {
private void doLookups(Map<String,Map<KeyExtent,List<Range>>> binnedRanges,
final ResultReceiver receiver, List<Column> columns) {
- if (timedoutServers.containsAll(binnedRanges.keySet())) {
- // all servers have timed out
- throw new TimedOutException(timedoutServers);
- }
-
- // when there are lots of threads and a few tablet servers
- // it is good to break request to tablet servers up, the
- // following code determines if this is the case
int maxTabletsPerRequest = Integer.MAX_VALUE;
- if (numThreads / binnedRanges.size() > 1) {
- int totalNumberOfTablets = 0;
- for (Entry<String,Map<KeyExtent,List<Range>>> entry :
binnedRanges.entrySet()) {
- totalNumberOfTablets += entry.getValue().size();
- }
- maxTabletsPerRequest = totalNumberOfTablets / numThreads;
- if (maxTabletsPerRequest == 0) {
- maxTabletsPerRequest = 1;
+ long busyTimeout = 0;
+ Duration scanServerDispatcherDelay = null;
+ Map<String,ScanAttemptsImpl.ScanAttemptReporter> reporters = Map.of();
+
+ if (options.getConsistencyLevel().equals(ConsistencyLevel.EVENTUAL)) {
Review Comment:
To make the ScanServerDispatcher support multiple threads would need to
modify the interface `ScanServerDispatcher.Actions` to allow communicating
intent about threads. That interface is how a dispatcher communicates what it
wants done. Would probably also need to modify
`ScanServerDispatcher.DispatcherParameters` to pass in information about the
number of threads available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
