ctubbsii commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r882269924
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java:
##########
@@ -419,6 +438,7 @@ public Options getOptions() {
outputFileOpt.setArgName("file");
contextOpt.setArgName("context");
executionHintsOpt.setArgName("<key>=<value>{,<key>=<value>}");
+ scanServerOpt.setArgName("immediate|eventual");
Review Comment:
> My thinking on the naming is that there are multiple way to implement
eventual consistency, with scan servers being one. From the the API perspective
I was thinking a user would declare they are ok with eventual consistency and
that runtime configuration would determine how that actually executes.
That makes sense if the desired primary outcome was "eventual consistency".
It's not, though. It's merely an acceptable side-effect of what the user is
really asking for, and not its essential/sufficient characteristic.
This would be like calling the BatchScanner an UnorderedScanner. There are
lots of ways to implement a scanner that returns data out of order. However,
the primary characteristic in that case is that it scans batches of ranges in
parallel, not that it's unordered. We've previously discussed that it really
should be called ParallelScanner instead, because that is its essential
characteristic. It is *necessarily* unordered, but it is *sufficient* to
describe it as parallel, because all its secondary characteristics, including
the fact that it returns results out of order, are merely side-effects of that
essential characteristic. The same principle is applicable to the naming for
this feature. We should really be naming it based on what is sufficient to
describe its essential characteristics, not describing a subset of its
necessary characteristics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
