dlmarion commented on code in PR #2732:
URL: https://github.com/apache/accumulo/pull/2732#discussion_r882636421


##########
server/manager/src/main/java/org/apache/accumulo/manager/tserverOps/ShutdownTServer.java:
##########
@@ -57,6 +57,13 @@ public long isReady(long tid, Manager manager) {
       return 0;
     }
 
+    // if one tserver is remaining throw an error and return before attempting 
shutdown
+    if (manager.onlineTabletServers().size() == 1) {
+      log.error("Only 1 tserver running and it contains the Root table. Not 
shutting down {}. ",
+          server);
+      return 0;

Review Comment:
   Nevermind, I see what's happening here. Might want to adjust the comment to 
say that by returning early the `manager.shutdownTServer` call is never made 
and the tserver will not be shut down.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to