keith-turner commented on code in PR #2746:
URL: https://github.com/apache/accumulo/pull/2746#discussion_r884138068
##########
assemble/conf/accumulo-env.sh:
##########
@@ -73,11 +73,13 @@ export CLASSPATH
## JVM options set for all processes. Extra options can be passed in by
setting ACCUMULO_JAVA_OPTS to an array of options.
read -r -a accumulo_initial_opts < <(echo "$ACCUMULO_JAVA_OPTS")
-JAVA_OPTS=("${accumulo_initial_opts[@]}"
+JAVA_OPTS=(
'-XX:OnOutOfMemoryError=kill -9 %p'
'-XX:-OmitStackTraceInFastThrow'
'-Djava.net.preferIPv4Stack=true'
- "-Daccumulo.native.lib.path=${lib}/native")
+ "-Daccumulo.native.lib.path=${lib}/native"
+ "${accumulo_initial_opts[@]}"
Review Comment:
This is interesting moving this last, will make the ACCUMULO_JAVA_OPTS
absolute last like you mentioned in the description. Makesme wonder if the -D
options can be overridden. If they can this change will facilitate it.
##########
assemble/conf/accumulo-env.sh:
##########
@@ -73,11 +73,13 @@ export CLASSPATH
## JVM options set for all processes. Extra options can be passed in by
setting ACCUMULO_JAVA_OPTS to an array of options.
read -r -a accumulo_initial_opts < <(echo "$ACCUMULO_JAVA_OPTS")
-JAVA_OPTS=("${accumulo_initial_opts[@]}"
+JAVA_OPTS=(
'-XX:OnOutOfMemoryError=kill -9 %p'
'-XX:-OmitStackTraceInFastThrow'
'-Djava.net.preferIPv4Stack=true'
- "-Daccumulo.native.lib.path=${lib}/native")
+ "-Daccumulo.native.lib.path=${lib}/native"
+ "${accumulo_initial_opts[@]}"
Review Comment:
This is interesting moving this last, will make the ACCUMULO_JAVA_OPTS
absolute last like you mentioned in the description. Makes me wonder if the -D
options can be overridden. If they can this change will facilitate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
