milleruntime commented on code in PR #2750:
URL: https://github.com/apache/accumulo/pull/2750#discussion_r891644230
##########
core/src/main/java/org/apache/accumulo/core/metadata/Reference.java:
##########
@@ -38,4 +38,28 @@ public Reference(TableId tableId, String metadataEntry) {
this.metadataEntry = metadataEntry;
this.tabletDir = metadataEntry;
}
+
+ @Override
+ public int compareTo(Reference that) {
+ if (equals(that)) {
+ return 0;
+ } else {
+ return this.metadataEntry.compareTo(that.metadataEntry);
+ }
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj instanceof Reference) {
+ Reference that = (Reference) obj;
+ return this.metadataEntry.equals(that.metadataEntry);
+ } else {
+ return false;
+ }
+ }
Review Comment:
OK, that is definitely more thorough. I will replace it.
As far as your comment about using all the fields, theoretically, the other
2 fields _should_ be contained in `metadataEntry`. I am not 100% positive
though cause the code is very complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
