milleruntime commented on code in PR #2767:
URL: https://github.com/apache/accumulo/pull/2767#discussion_r896686033
##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -170,6 +172,9 @@ private void
removeCandidatesInUse(GarbageCollectionEnvironment gce,
log.debug("Candidate was still in use: {}", relativePath);
}
}
+
+ // close underlying scanner
+ refStream.close();
Review Comment:
That is a good question. I was thinking it closes both but maybe I can write
a test to see. The scanner was being closed by the `try-with-resources` on the
`TabletsMetadata` but that class is the one that is `AutoCloseable`. If we want
to be able to close the underlying scanner (which I think would be good) then
we probably have to refactor the GC code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
