EdColeman commented on code in PR #2786:
URL: https://github.com/apache/accumulo/pull/2786#discussion_r908560850
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/MergeInfo.java:
##########
@@ -93,10 +100,16 @@ public boolean needsToBeChopped(KeyExtent otherExtent) {
}
public boolean overlaps(KeyExtent otherExtent) {
- boolean result = this.extent.overlaps(otherExtent);
- if (!result && needsToBeChopped(otherExtent))
- return true;
- return result;
+ return previouslyEvaluatedOverlaps.computeIfAbsent(otherExtent, b -> {
+ boolean result = this.extent.overlaps(otherExtent);
+ if (!result && needsToBeChopped(otherExtent))
+ result = true;
+ if (result)
+ LOG.debug("mergeInfo overlaps: {} true", extent);
Review Comment:
This provides additional context,which may be helpful - otherwise the extent
is repeated in the log as the overlap is calculated,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
