dlmarion commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r939180684
##########
core/src/test/java/org/apache/accumulo/core/file/blockfile/cache/TestLruBlockCache.java:
##########
@@ -76,7 +76,9 @@ public void testConfiguration() {
// this is not set for the cache type, so should fall back to default
cc.set(defaultPrefix + LruBlockCacheConfiguration.MAP_LOAD_PROPERTY,
"0.53");
- BlockCacheConfiguration bcc = new BlockCacheConfiguration(cc);
+ BlockCacheConfiguration bcc = new BlockCacheConfiguration(cc,
Property.TSERV_PREFIX,
+ Property.TSERV_INDEXCACHE_SIZE, Property.TSERV_DATACACHE_SIZE,
+ Property.TSERV_SUMMARYCACHE_SIZE, Property.TSERV_DEFAULT_BLOCKSIZE);
Review Comment:
Addressed in 9ec7f5f. I modified BlockCacheConfiguration to create two
static methods that returned either a configuration for the TabletServer or the
ScanServer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
