DomGarguilo commented on code in PR #2928:
URL: https://github.com/apache/accumulo/pull/2928#discussion_r969985833
##########
test/src/main/java/org/apache/accumulo/test/LargeSplitRowIT.java:
##########
@@ -130,38 +129,35 @@ public void automaticSplitWith250Same() throws Exception {
// make a table and lower the configure properties
final String tableName = getUniqueNames(1)[0];
try (AccumuloClient client =
Accumulo.newClient().from(getClientProperties()).build()) {
- client.tableOperations().create(tableName);
- client.tableOperations().setProperty(tableName,
Property.TABLE_SPLIT_THRESHOLD.getKey(),
- "10K");
- client.tableOperations().setProperty(tableName,
Property.TABLE_FILE_COMPRESSION_TYPE.getKey(),
- "none");
- client.tableOperations().setProperty(tableName,
- Property.TABLE_FILE_COMPRESSED_BLOCK_SIZE.getKey(), "64");
- client.tableOperations().setProperty(tableName,
Property.TABLE_MAX_END_ROW_SIZE.getKey(),
- "1000");
-
- // Create a BatchWriter and key for a table entry that is longer than
the allowed size for an
+ Map<String,String> props = new HashMap<>();
Review Comment:
Could do:
```java
// @formatter:off
Map<String,String> props = Map.of(
Property.TABLE_SPLIT_THRESHOLD.getKey(), "10K",
Property.TABLE_FILE_COMPRESSION_TYPE.getKey(), "none",
Property.TABLE_FILE_COMPRESSED_BLOCK_SIZE.getKey(), "64",
Property.TABLE_MAX_END_ROW_SIZE.getKey(), "1000"
);
// @formatter:on
```
or
```java
Map<String,
String> props = Map.of(Property.TABLE_SPLIT_THRESHOLD.getKey(),
"10K",
Property.TABLE_FILE_COMPRESSION_TYPE.getKey(), "none",
Property.TABLE_FILE_COMPRESSED_BLOCK_SIZE.getKey(), "64",
Property.TABLE_MAX_END_ROW_SIZE.getKey(), "1000");
```
with default formatting which isn't too unreadable. Do you think either of
these would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
