keith-turner commented on code in PR #2792:
URL: https://github.com/apache/accumulo/pull/2792#discussion_r974625599
##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -171,8 +180,47 @@ public Stream<Reference> getReferences() {
}
@Override
- public Set<TableId> getTableIDs() {
- return context.getTableIdToNameMap().keySet();
+ public Map<TableId,TableState> getTableIDs() throws InterruptedException {
+ final String tablesPath = context.getZooKeeperRoot() + Constants.ZTABLES;
+ final ZooReader zr = context.getZooReader();
+ int retries = 1;
+ UncheckedIOException ioe = null;
+ while (retries <= 10) {
+ try {
+ zr.sync(tablesPath);
+ final Map<TableId,TableState> tids = new HashMap<>();
+ for (String table : zr.getChildren(tablesPath)) {
+ TableId tableId = TableId.of(table);
+ TableState tableState = null;
+ String statePath = context.getZooKeeperRoot() + Constants.ZTABLES +
"/"
+ + tableId.canonical() + Constants.ZTABLE_STATE;
+ try {
+ byte[] state = zr.getData(statePath, null, null);
+ if (state == null) {
+ tableState = TableState.UNKNOWN;
+ } else {
+ tableState = TableState.valueOf(new String(state, UTF_8));
+ }
+ } catch (KeeperException e) {
+ if (e.code() == Code.NONODE) {
+ tableState = TableState.UNKNOWN;
+ }
+ throw e;
Review Comment:
Should this be if/else?
```suggestion
if (e.code() == Code.NONODE) {
tableState = TableState.UNKNOWN;
} else {
throw e;
}
```
May not matter if we change to use NoNodeException that I commented on in
other thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
