milleruntime commented on code in PR #2986:
URL: https://github.com/apache/accumulo/pull/2986#discussion_r984516641
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -93,6 +93,15 @@ void modifyProperties(Consumer<Map<String,String>>
mapMutator) throws AccumuloEx
*/
Map<String,String> getSystemConfiguration() throws AccumuloException,
AccumuloSecurityException;
+ /**
+ * Retrieves the configured System properties from zookeeper. This method is
different from
+ * {@link #getSystemConfiguration()} as it will only return the configured
properties in zookeeper
+ * and not properties from accumulo.properties or defaults.
+ *
+ * @return a map of system properties set in zookeeper
+ */
+ Map<String,String> getSystemProperties() throws AccumuloException,
AccumuloSecurityException;
Review Comment:
> query what properties were set vs what are defaults so the user can know
what's been changed, etc.
I'm confused. If the new `modifyProperties()` does not throw an exception,
then won't all the properties passed in be set? From a user perspective, is
there a situation where the properties I pass to the method don't all get set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
