dlmarion commented on code in PR #2990:
URL: https://github.com/apache/accumulo/pull/2990#discussion_r984898354
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -225,6 +226,35 @@ public boolean stillManager() {
return getManagerState() != ManagerState.STOP;
}
+ Fate<Manager> fate() {
+ Fate<Manager> fate = fateReady.get();
+ if (fate != null) {
+ // it's ready, just return it
+ return fate;
+ }
+
+ // it's not ready yet
+ long retryTime = 500; // millis
+
+ // create informative warning
+ String msgPrefix = "Unexpected use of fate in thread " +
Thread.currentThread().getName()
+ + " at time " + System.currentTimeMillis();
+ log.warn("{} blocked until fate starts", msgPrefix,
+ new IllegalStateException("Attempted fate action before fate was
started; "
+ + "if this doesn't make progress, please report it as a bug to the
developers"));
Review Comment:
So, regarding the logging, you could do something like this instead:
```
if (!fateReadyLatch.await(1, MINUTE)) {
// LOG HERE
}
```
The waiting should be short-circuited when the latch count goes to zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
