keith-turner commented on PR #236: URL: https://github.com/apache/accumulo-testing/pull/236#issuecomment-1269650250
> I'm beginning to wonder if we should replace the stream with the original loop. The created set must always have at least 0 in it. Will the stream changes I created with Stream.concat result in this? I looked at the stream javadoc and it will maintain order, so since `0` comes first it should always be there. https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/stream/Stream.html#concat(java.util.stream.Stream,java.util.stream.Stream) I think the stream code may be slightly more readable than the loop with the explicit call to distinct(). So I think its slightly better than the loop. I am going to add a comment about zero. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
