ctubbsii commented on code in PR #3021:
URL: https://github.com/apache/accumulo/pull/3021#discussion_r995774367
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/log/RecoveryLogsIterator.java:
##########
@@ -77,7 +79,7 @@ public RecoveryLogsIterator(ServerContext context, List<Path>
recoveryLogDirs, L
for (Path logDir : recoveryLogDirs) {
LOG.debug("Opening recovery log dir {}", logDir.getName());
- List<Path> logFiles = getFiles(vm, logDir);
+ SortedSet<Path> logFiles = getFiles(vm, logDir);
Review Comment:
I'm not sure the full implications here, but I would have assumed insert
order, as they appear in the metadata, would be more important than ordering by
path, which could vary due to hostname differences on the HDFS volume. If the
files have unique 1-up sequence based names, you could use a custom comparator
to order them that way in a set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
