ctubbsii commented on code in PR #3142:
URL: https://github.com/apache/accumulo/pull/3142#discussion_r1059458662
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -726,6 +726,14 @@ public enum Property {
"The number of threads on each tablet server available to retrieve"
+ " summary data, that is not currently in cache, from RFiles.",
"2.0.0"),
+ TSERV_LAST_LOCATION_MODE("tserver.last.location.mode", "compact",
PropertyType.LAST_LOCATION_MODE,
+ "Describes how the system will assign tablets initially by defining how
the 'last' location is updated."
Review Comment:
```suggestion
"Describes how the system will record the 'last' location for tablets,
which can be used for assigning them when a cluster restarts."
```
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java:
##########
@@ -83,25 +91,30 @@ public void setFutureLocations(Collection<Assignment>
assignments)
}
@Override
- public void unassign(Collection<TabletLocationState> tablets,
+ public void unassign(ServerContext context, Collection<TabletLocationState>
tablets,
Review Comment:
I think we probably don't need to keep passing in ServerContext to each
instance method if we just add it to the constructor.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -726,6 +726,14 @@ public enum Property {
"The number of threads on each tablet server available to retrieve"
+ " summary data, that is not currently in cache, from RFiles.",
"2.0.0"),
+ TSERV_LAST_LOCATION_MODE("tserver.last.location.mode", "compact",
PropertyType.LAST_LOCATION_MODE,
+ "Describes how the system will assign tablets initially by defining how
the 'last' location is updated."
+ + " If 'compact' is the mode, then the system will assign tablets
based on the data locality (e.g. the last compaction location)."
+ + " If 'assign' is the mode, then tablets will be initially assigned
to the last place they were assigned."
Review Comment:
```suggestion
+ " If 'assign' is the mode, then the most recently assigned
location will be recorded."
```
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -726,6 +726,14 @@ public enum Property {
"The number of threads on each tablet server available to retrieve"
+ " summary data, that is not currently in cache, from RFiles.",
"2.0.0"),
+ TSERV_LAST_LOCATION_MODE("tserver.last.location.mode", "compact",
PropertyType.LAST_LOCATION_MODE,
+ "Describes how the system will assign tablets initially by defining how
the 'last' location is updated."
+ + " If 'compact' is the mode, then the system will assign tablets
based on the data locality (e.g. the last compaction location)."
+ + " If 'assign' is the mode, then tablets will be initially assigned
to the last place they were assigned."
+ + " If 'unload' is the mode, then tablets will be initially assigned
to the last place they were unloaded from (i.e. requires a clean shutdown)."
Review Comment:
```suggestion
+ " If 'unload' is the mode, then tablets will be initially
assigned to the last place they were unloaded from (i.e. requires a clean
shutdown)."
```
I'm not sure we need this one at all. This would require a clean shut down
in order to freeze the current assignments. And, in the case of that clean shut
down, this would be no different than the `assign` mode. If there is not a
clean shutdown, then the field would merely be blank... which isn't helpful.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -726,6 +726,14 @@ public enum Property {
"The number of threads on each tablet server available to retrieve"
+ " summary data, that is not currently in cache, from RFiles.",
"2.0.0"),
+ TSERV_LAST_LOCATION_MODE("tserver.last.location.mode", "compact",
PropertyType.LAST_LOCATION_MODE,
+ "Describes how the system will assign tablets initially by defining how
the 'last' location is updated."
+ + " If 'compact' is the mode, then the system will assign tablets
based on the data locality (e.g. the last compaction location)."
Review Comment:
```suggestion
+ " If 'compact' is the mode, then the system will record the
location where the tablet's most recent compaction occurred."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
