DomGarguilo commented on code in PR #15:
URL:
https://github.com/apache/accumulo-classloaders/pull/15#discussion_r1063835749
##########
pom.xml:
##########
@@ -340,11 +350,15 @@
</module>
<module name="RegexpSinglelineJava">
<property name="format"
value="junit[.]framework[.]TestCase" />
- <property name="message" value="Use JUnit4+ @Test
annotation instead of TestCase" />
+ <property name="message" value="Use JUnit5+ @Test
annotation instead of TestCase" />
Review Comment:
> I think we still need some JUnit4 tests in the main project, because we
use PowerMock there
Oh yea I forgot about that.
I added a rule that makes sure only Junit Jupiter imports are used instead
of just looking for a Junit4 `@Test` import. Take a look at
[ecc0d00](https://github.com/apache/accumulo-classloaders/pull/15/commits/ecc0d0023de38838281dd9224830ad79344a1da9)
and let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
