dlmarion commented on code in PR #3167:
URL: https://github.com/apache/accumulo/pull/3167#discussion_r1084007998
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1012,16 +1013,19 @@ private SortedMap<TServerInstance,TabletServerStatus>
gatherTableInformation(
badServers.remove(server);
}
}
- });
- }
- tp.shutdown();
- try {
- tp.awaitTermination(Math.max(10000, rpcTimeout / 3),
TimeUnit.MILLISECONDS);
- } catch (InterruptedException e) {
- log.debug("Interrupted while fetching status");
+ }));
}
- tp.shutdownNow();
+ // Wait for all tasks to complete
+ while (!tasks.isEmpty()) {
Review Comment:
Updated logic in 967df31 to wait 1 second between the outer loop and to
cancel tasks if they have not completed in the same amount of time as the old
logic used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
