EdColeman commented on code in PR #3146:
URL: https://github.com/apache/accumulo/pull/3146#discussion_r1084464373
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java:
##########
@@ -353,6 +344,31 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
return 0;
}
+ private void validatePropertyType(String property, String value, String
fullCommand,
+ String tableName) throws BadArgumentException {
+ if (tableName != null) {
+ if (!Property.isValidTablePropertyKey(property)) {
+ throw new BadArgumentException("Invalid per-table property: " +
property, fullCommand,
+ fullCommand.indexOf(property));
+ }
+ }
+ if (!Property.isValidZooPropertyKey(property)) {
Review Comment:
Should this be checked first? It does not really matter if it is in the
correct format or not if it can never be change in ZooKeeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
