dlmarion commented on code in PR #3172:
URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086535003
##########
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java:
##########
@@ -213,7 +213,7 @@ public ClientSideIteratorScanner(final Scanner scanner) {
smi = new ScannerTranslatorImpl(scanner,
scanner.getSamplerConfiguration());
this.range = scanner.getRange();
this.size = scanner.getBatchSize();
- this.timeOut = scanner.getTimeout(MILLISECONDS);
+ this.retryTimeout = scanner.getTimeout(MILLISECONDS);
this.batchTimeOut = scanner.getTimeout(MILLISECONDS);
Review Comment:
It appears that the use of timeout between Scanner and BatchScanner is
inconsistent. Even though they use the same API method the BatchScanner
actually times out. This is an issue we should fix. This PR is step 1 I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
