ctubbsii commented on PR #3142: URL: https://github.com/apache/accumulo/pull/3142#issuecomment-1405281252
@ivakegg asked: > @ctubbsii Are you now ok with this PR or do you hvae additional concerns? Do you want additional PRs to go against 2.1 and 1.10 ? I don't have any other concerns, and I'm okay with this for 2.1.1, but the PR will need to be remade for that, and the since version for the property will need to be updated. For 1.10, I don't think it's worth it... the code is very different and it would require changing the "since" information to the property from a simple "2.1.1" to a more complicated "1.10.3, but not 2.x before 2.1.1, then from 2.1.1 onward". It's just very confusing to manage expectations for users when we try to backport new features. I'm okay with 2.1.1 only because there's no harm if the user has this set for 2.1.0... the property would just be ignored... and because there's no API changes or substantive behavior changes, just an optimization knob. To add to 2.1.1, I'm going to create a temporary working branch, switch the base branch for this PR to that, merge it, then cherry-pick it to 2.1 and update the references to 3.0.0 to 2.1.1. Then I'll merge it forward to the main branch and get rid of the temporary working branch. That way, it's just easier on you and you don't need to create a new PR, and we can get this merged in sooner to 2.1. If 1.10 is desired, we'll need a new PR... to backport, and the merge forward will be a little complicated... but as I said, I do not think we should do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
