cshannon commented on code in PR #3136:
URL: https://github.com/apache/accumulo/pull/3136#discussion_r1103858054
##########
start/src/main/java/org/apache/accumulo/start/Main.java:
##########
@@ -38,20 +37,17 @@ public class Main {
private static final Logger log = LoggerFactory.getLogger(Main.class);
private static ClassLoader classLoader;
- private static Class<?> vfsClassLoader;
private static Map<String,KeywordExecutable> servicesMap;
public static void main(final String[] args) throws Exception {
// Preload classes that cause a deadlock between the ServiceLoader and the
DFSClient when
// using the VFSClassLoader with jars in HDFS.
ClassLoader loader = getClassLoader();
- Class<?> confClass = null;
+ Class<?> confClass;
try {
- @SuppressWarnings("deprecation")
- var deprecatedConfClass =
org.apache.accumulo.start.classloader.AccumuloClassLoader
- .getClassLoader().loadClass("org.apache.hadoop.conf.Configuration");
- confClass = deprecatedConfClass;
- Object conf = null;
+ confClass =
+
ClassLoader.getSystemClassLoader().loadClass("org.apache.hadoop.conf.Configuration");
+ Object conf;
Review Comment:
I can remove this but I was thinking that wouldn't this issue still be a
problem if a user configured Accumulo to use the VFS classloader that is now
external?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
