EdColeman opened a new pull request, #3195:
URL: https://github.com/apache/accumulo/pull/3195
- Uses Collections.unmodifiableList to limit the exposure of the PRIVATE and
PUBLIC collections.
- Adds tests that replicate the current ZooKeeper check (in ZooKeeper, the
method is private)
Spotbugs warns (MS_MUTABLE_COLLECTION) for the the public, static
definitions in ZooUtil for PRIVATE and PUBLIC ZooKeeper ACLs that expose a
mutable collection (ArrayList). This was discovered when refactoring
ServiceLock from fate to another package in core. Verified, that with this
change, spotbugs does not flag the issue.
Using an immutable collection like List.of() or List.copyOf() result in an
NPE from ZooKeeper. ZooKeeper that performs a ACL check on operations like
create,... The ZooKeeper check calls `acl.contains((Object) null)` which throws
an NPE in Java (JDK-8265905)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
