FineAndDandy commented on code in PR #3221:
URL: https://github.com/apache/accumulo/pull/3221#discussion_r1123112407
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1814,7 +1824,7 @@ List<FileRef> findChopFiles(KeyExtent extent,
Map<FileRef,Pair<Key,Key>> firstAn
public synchronized boolean needsSplit() {
if (isClosing() || isClosed())
return false;
- return findSplitRow(getDatafileManager().getFiles()) != null;
+ return isSplitPossible();
Review Comment:
I agree there are additional checks, and this could lead to more rows being
queued up for split than are strictly necessary, but the full check is
performed by calling `findSplitRow()` when a split is queued up by calling
`needsSplit()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
