DomGarguilo commented on PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#issuecomment-1454167919

   > I'm still not sure what the volatile on the byte array buffer is doing, 
though... that doesn't seem to have any impact, as far as I can tell.
   
   I made it final in b821992
   
   Also, I tried to refactor some of the repeated logic in aa0f2c9. Not sure if 
it is an improvement in terms of readability (or anything else for that 
matter). I am not opposed to reverting the commit, take a look and let me know 
what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to