keith-turner commented on code in PR #3274:
URL: https://github.com/apache/accumulo/pull/3274#discussion_r1157637939
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:
##########
@@ -182,6 +183,18 @@ default TabletsMutator mutateTablets() {
throw new UnsupportedOperationException();
}
+ /**
+ * Use this method to fix or rollback an incomplete split operation.
+ *
+ * @param tabletMetadata tablet meta to fix
+ * @param lock Zookeeper lock to pass to the finishSplit operation.
+ * @return KeyExtent of a fixed split
+ */
+ default KeyExtent fixSplit(TabletMetadata tabletMetadata, ServiceLock lock)
Review Comment:
I see Ample as an abstraction layer for reading and writing accumulo
metadata. The implementation of this method does more than simply read and
write, it does read+manipulate+write. Its only used by one class
(AssignmentHandler) and a test. We could place this code as a static method in
AssignmentHandler instead of here in Ample.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
