dlmarion commented on code in PR #3276: URL: https://github.com/apache/accumulo/pull/3276#discussion_r1157660609
########## core/src/main/java/org/apache/accumulo/core/security/Authorizations.java: ########## @@ -45,6 +46,9 @@ public class Authorizations implements Iterable<byte[]>, Serializable, Authoriza private final Set<ByteSequence> auths; private final List<byte[]> authsList; // sorted order + private static final Pair<Set<ByteSequence>,List<byte[]>> EMPTY_INTERNAL_COLLECTIONS = Review Comment: While I agree that `INTERNAL in `EMPTY_INTERNAL_COLLECTIONS` may be redundant given that the variable is private, I don't agree that the length of the name reduces readability or that the name is confusing. `DEFAULT_EMPTY` as a variable name may contain less characters, but I don't think it provides *more* clarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
