EdColeman commented on PR #3297: URL: https://github.com/apache/accumulo/pull/3297#issuecomment-1508859008
Over-all it seemed that it was not providing information that was not already there - its a thrift metric, the process is identified so repeating that it was in the client server handler could be inferred. From the samples seen, the tag was appearing as either `thread=Thrift Client Server` or `Manager Client Service Handler` If it could take on different values, it also seemed unlikely that it would be something that end-users would need to trend / watch by specific thread. Monitoring thift times could provide a view into the health of the processes - knowing it was a specific thread seemed like something that would be needed by developers that were profiling specific code sections and metrics may not be the best way to determine that specific thrift thread timing. Each different tag value increase the number of time-series that need to be tracked. It did not seem necessary to potentially increase the number of time-series than need to be tracked (assuming it could take different values) - but I can restore it if there is a use-case that I am unaware of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
