keith-turner commented on code in PR #3292:
URL: https://github.com/apache/accumulo/pull/3292#discussion_r1172004877
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftScanner.java:
##########
@@ -299,10 +305,52 @@ public ScanState(ClientContext context, TableId tableId,
Authorizations authoriz
}
}
- public static class ScanTimedOutException extends IOException {
+ static <T> Optional<T> waitUntil(Supplier<Optional<T>> condition, Duration
maxWaitTime,
Review Comment:
This method has some things very specific to scans in it so it could not be
moved as is. However it could build on a more generic method and pass the scan
specific code in as a lambda.
We may benefit from by combining functionality in the Retry and Wait classes
to create a new class that can implement retry more succinctly throughout the
code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
