ctubbsii commented on code in PR #384: URL: https://github.com/apache/accumulo-website/pull/384#discussion_r1175922007
########## build-images.sh: ########## Review Comment: I figured there might be a need to keep the Dockerfile at the root. That's fine. As for shellcheck, I thought it was available in EPEL for CentOS. It's written in Haskell, so maintaining its dependencies might be a problem for some versions of CentOS. It might also be available as a snap. But, another option is to just paste the contents into https://www.shellcheck.net/ if you don't want to install it. In the main Accumulo repo, we have a GitHub Actions check for it. I haven't gotten around to adding that to our other repos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
