ddanielr commented on code in PR #384: URL: https://github.com/apache/accumulo-website/pull/384#discussion_r1178104394
########## Dockerfile: ########## @@ -0,0 +1,40 @@ +# This Dockerfile builds an ruby environment for jekyll that empowers +# making updates to the accumulo website without requiring the dev +# to maintain a local ruby development environment. + +FROM ruby:2.7.8-slim-bullseye as base + +RUN apt-get update && apt-get install -y --no-install-recommends \ + build-essential \ + git \ + curl \ + && rm -rf /var/lib/apt/lists/* + +WORKDIR /site + + +# Copy over the Gemfiles so that all build dependencies are installed +# during build vs at runtime. + +COPY Gemfile /site/Gemfile +COPY Gemfile.lock /site/Gemfile.lock Review Comment: > This is what I was noticing. Specifically, we're relying on it being the same for RUN and CMD, even though those run at completely separate phases. I was thinking that we might want to be in one directory for building the image, and another directory when we run the container. Not sure if there's a way to control that with that much granularity. Can always `(cd /somewhere else && dosomething)`, I suppose. I don't know what benefit you get from being in a different directory that would justify the change. Overall this Dockerfile is pretty simple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
