ctubbsii opened a new pull request, #3378: URL: https://github.com/apache/accumulo/pull/3378
* Remove support for Hadoop map files for tablet data, as this hasn't worked since 1.5.0 anyway. Now, an error should be thrown, as the file type is no longer recognized. Replaced special handling for map file extension or directory with a logged warning, error, or allow an exception to be thrown, depending on the situation. * Rename 'mapFile' variables and related methods to the more generic 'dataFile' or equivalent, to reduce confusion, since we no longer use MyMapFile or Hadoop MapFile, and only use RFile for storing tablet data files. This was done once before when RFile was initially added to the code base, which is why many of our variables and types already used the term 'dataFile', but evidently, not all of it had been renamed, or some of that terminology leaked back in. Some of it was added as part of recent Compaction changes, but there may have been earlier times this language was added back in. This change here resets us to the generic language for tablet data files. * Rename and relocate tabletingest-specific Thrift struct MapFileInfo to DataFileInfo under the tabletingest.thrift namespace. This only affects the bulk load Manager FATE operation and tablet servers. End user clients did not use this API, so it will not affect them. * Rename loadMapFile variable to loadMappingFile to make it clear that it's the file that stores the mapping of files for bulk loads, rather than a file in the MapFile format. * Add new validator to `table.file.type` value to prevent it from being anything other than the currently supported 'rf' extension for RFiles, which is also the current default (and the only value that would have worked anyway). * Fix issues with DefaultCompactionPlanner reported as part of #3377, but those should be applied to 2.1 branch first, and this change rebased onto the updated main after that is merged forward. **TODO** remove this from the commit message once that's done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
