dlmarion commented on code in PR #3447:
URL: https://github.com/apache/accumulo/pull/3447#discussion_r1218095375
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementScanner.java:
##########
@@ -46,9 +47,11 @@ public class TabletManagementScanner implements
ClosableIterator<TabletManagemen
private final BatchScanner mdScanner;
private final Iterator<Entry<Key,Value>> iter;
private final AtomicBoolean closed = new AtomicBoolean(false);
+ private final ConcurrentLinkedQueue<TabletManagement>
knownTabletModifications;
- TabletManagementScanner(ClientContext context, Range range, CurrentState
state,
- String tableName) {
+ // This constructor is called from TabletStateStore implementations
+ public TabletManagementScanner(ClientContext context, Range range,
CurrentState state,
+ String tableName, ConcurrentLinkedQueue<TabletManagement>
knownTabletModifications) {
Review Comment:
The way that this currently works is that anything added to the
knownTabletModifications gets priority. So, if a tablet hosting request comes
in then it will be processed before regular metadata table scanning. I think
that's correct. With your suggestion above, if the TGW was in the middle of
scanning the metadata table, then the processing of the hosting request would
wait until the metadata table scanning had completed. Thinking about priority,
I wonder if tablet hosting requests might be the only place where this is
used. I don't know that splits, merges or compactions of a tablet should take
priority over hosting, splits, merges or compactions of any other tablet in the
metadata table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
