EdColeman commented on code in PR #3445:
URL: https://github.com/apache/accumulo/pull/3445#discussion_r1223622717
##########
test/src/main/java/org/apache/accumulo/test/start/KeywordStartIT.java:
##########
@@ -201,6 +203,8 @@ public void checkHasMain() {
expectSet.add(Shell.class);
expectSet.add(SimpleGarbageCollector.class);
expectSet.add(TabletServer.class);
+ expectSet.add(ZooInfoViewer.class);
+ expectSet.add(ZooPropSetTool.class);
Review Comment:
What determines when a tool should have a main method? The javadoc in
`KeywordExecutable` states how, if it is desired to have a "redundant main
method" what it should look like. Certainly using `accumulo tool-name` is
convenient, but I do not know when someone might prefer using a main method, or
which tools "require" a main method, other than the list in KeywordStartIT,
which I think over time may be testing tools that "have a main method" vs. test
tools that actually "require" a main main, but have one for convenience (or in
my case added because of ignorance of the difference.)
The Keyword and main support seems to mainly be boiler-plate between
utilities and I was trying to maintain similar functionality between various
tools so that would provide similar experiences rather than the user needing
know tool-by-tool which options it would support,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
