keith-turner commented on code in PR #3533: URL: https://github.com/apache/accumulo/pull/3533#discussion_r1240173478
########## minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/ClusterServerConfiguration.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.miniclusterImpl; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.Map; + +import org.apache.accumulo.core.lock.ServiceLockData; + +public class ClusterServerConfiguration { Review Comment: I was thinking when a new config is set it reconciles that with what is currently running and starts/stops processes. Not sure what that would look like in practice. We could also have an internal non public API version that is mutable. I think making the API version immutable is nice as minis public API does not allow starting and stopping servers after the cluster starts, that seems to be something internal that we use for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
