DomGarguilo commented on PR #3544: URL: https://github.com/apache/accumulo/pull/3544#issuecomment-1609619071
> The fact that it's a SecureRandom vs. just a Random is expressed in the type, either way, so I don't think putting the `SECURE` in the name (or even just `S`) helps make the calling code any more readable over `RNG` I agree. I think that `RANDOM` and `RNG` are my top choices for renaming but I'm leaning towards `RANDOM` just so it is a bit clearer what the variables type is. Also it seems like when we created `SecureRandom` objects throughout the code, we often use "random" as the variable name so it would be more consistent with what is already present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
