dtspence opened a new pull request, #3549:
URL: https://github.com/apache/accumulo/pull/3549

   * Creates TabletFile path with URI, which avoids a regex validation.
   * Updates validateFileName to check explicit characters.
   * Unit test for ValidationUtil.
   
   Fixes #3499
   
   -- 
   
   The following are pre/post benchmarks for updates:
   
   ```
   Accumulo 2.1.2-SNAPSHOT (current):
   Benchmark                                                   (splitsRfile)  
Mode  Cnt    Score     Error  Units
   GarbageCollectorPerformanceIT.benchmarkReferences                   1,100  
avgt    3    1.665 ±   0.211  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op          1,100  
avgt    3    0.017 ±   0.002  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences                  10,100  
avgt    3   10.139 ±  16.299  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op         10,100  
avgt    3    0.010 ±   0.016  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences                 100,100  
avgt    3   62.035 ±  24.129  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op        100,100  
avgt    3    0.006 ±   0.002  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences                1000,100  
avgt    3  521.994 ± 228.079  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op       1000,100  
avgt    3    0.005 ±   0.002  ms/op
   
   
   Accumulo 2.1.2-SNAPSHOT (PR changes):
   Benchmark                                                   (splitsRfile)  
Mode  Cnt    Score    Error  Units
   GarbageCollectorPerformanceIT.benchmarkReferences                   1,100  
avgt    3    1.374 ±  0.160  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op          1,100  
avgt    3    0.014 ±  0.002  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences                  10,100  
avgt    3    6.562 ±  2.008  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op         10,100  
avgt    3    0.007 ±  0.002  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences                 100,100  
avgt    3   38.382 ± 10.472  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op        100,100  
avgt    3    0.004 ±  0.001  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences                1000,100  
avgt    3  233.692 ± 14.204  ms/op
   GarbageCollectorPerformanceIT.benchmarkReferences:rfile/op       1000,100  
avgt    3    0.002 ±  0.001  ms/op
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to