ctubbsii commented on PR #3549: URL: https://github.com/apache/accumulo/pull/3549#issuecomment-1613235858
I moved the new unit test to the correct package and pushed it to 2.1 in 2ec2321df8da0c90d2836561a2d16895e9bad0b5 so it can provide test coverage, regardless of what we want to do here. I updated the title of this PR since it's no longer about removing regexes, which perform similarly to the alternatives previously proposed in this PR according to the benchmarks, once the Pattern is compiled once, instead of each time it is evaluated. Of course, you can still update this PR to remove the regex now and replace it with one of the alternatives, but I don't think it's necessary anymore, and I dropped it when I resolved this PR's merge conflicts with the 2.1 branch after #3554 was merged. Based on the benchmarking, the main optimization that was included here was the use of the URI-based constructor for Path. So now, after resolving merge conflicts, that's the only thing left in this PR. I would have already merged that in, as well, but I am not sure about the TabletFile changes in 3.0, and this doesn't merge forward cleanly, since the TabletFile code changed. I'm not sure where this equivalent code moved to, if it even still applies to the main brnch. I don't want to merge it in to 2.1 until there's a plan for merging it forward into the main branch, even if that plan is to just make the change in 2.1, and do benchmarking and further changes separately for the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
