keith-turner commented on code in PR #3810:
URL: https://github.com/apache/accumulo/pull/3810#discussion_r1347967061
##########
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:
##########
@@ -43,11 +43,11 @@
public class Authorizations implements Iterable<byte[]>, Serializable,
AuthorizationContainer {
private static final long serialVersionUID = 1L;
- private static final Set<ByteSequence> EMPTY_AUTH_SET =
Collections.emptySet();
- private static final List<byte[]> EMPTY_AUTH_LIST = Collections.emptyList();
+ private static final HashSet<ByteSequence> EMPTY_AUTH_SET = new HashSet<>();
+ private static final ArrayList<byte[]> EMPTY_AUTH_LIST = new ArrayList<>();
Review Comment:
It would be good to keep those immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
