keith-turner opened a new issue, #3878:
URL: https://github.com/apache/accumulo/issues/3878
The LogEntry class has some technical debt that would be good to cleanup.
The following improvements could be made.
* There is a field named filename that actually seems to store a fully
qualified path. Could rename this field Could also add validation to this
field to ensure its of the expected format.
* There is a field named extent that is only used by unit test, could
probably remove this.
* There is no equals or hashCode method, these could be added.
* There is upgrade code in the class that deals with some old format of the
data. Can not see any test for this. Could remove if this if adding
validation that would fail on seeing this. Could possibly look for this in
upgrade and covert,if we can figure out what the old format was. However the
old format may be really old and seeing it may be unexpected or not
realistically possible.
* The value in the metadata table seems to store the exact same data as the
column qualifier. This code could be cleaned up to not store redundant info,
may require change in upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
