ctubbsii commented on issue #2264: URL: https://github.com/apache/accumulo/issues/2264#issuecomment-1778129946
It looks like there are 3 separate tasks for this: 1. Make sure `-f, --show-few` stops showing up in the MaxRowCommand's help 2. Make sure GrepCommand (and by extension, EGrepCommand) make use of the `showFewOpt` in a similar way as in ScanCommand 3. Make sure `--show-few` is not documented and does not function in the DeleteManyCommand (the corresponding shortname `-f` is already clobbered for `--force` in this command) The much cleaner solution is to just get rid of the `-f, --show-few` option entirely. It's an edge case for formatting output that is probably just not needed, as it adds too much complexity. Another option is to split out the construction of the ScanCommand options into those without the `-f, --show-few` option and those with it. The ScanCommand itself could use the version with it, but subclasses could use the set of options without it. That way, it still works on the ScanCommand where it's documented and working already, but is removed from the help for any subclasses. The only issue with this is that you really have to be careful to get the correct set of options in all of ScanCommand's subclasses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
