dlmarion commented on PR #27: URL: https://github.com/apache/accumulo-access/pull/27#issuecomment-1781546247
I was wondering earlier about this change in `AccessEvaluatorImpl`. ``` - .collect(Collectors.toList()); + .collect(Collectors.toUnmodifiableList()); ``` Looking at the sources ([toList](https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/util/stream/Collectors.java#L277), [toUnmodifiableList](https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/util/stream/Collectors.java#L296)), you will see that `toUnmodifiableList` is similar to `toList`, except after collecting to a List it calls `List.of(list.toArray())`. Could you back out this one change and run the benchmark on your branch again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
