cshannon commented on PR #3900: URL: https://github.com/apache/accumulo/pull/3900#issuecomment-1783553981
@keith-turner - I added the requested changes but one thing I was just thinking is that I added the WALs check to the deleteTablets code but we shouldn't really care about that if we are deleting the tablets anyways. We would only care about the tablets at the start/end of the delete that are being kept so not sure if I need to keep the check. It probably doesn't hurt to keep it so it's in a consistent state and we don't have to deal with edge cases around start/end range. Things are also a bit different depending on the version. In 2.1 obviously tablets chopped and splitt at the deletion range and whole tablets are gone but things work different with no chop merge and fencing (fence start/end tablet without splitting) and in elasticity (fence and merge empty tablets) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
